Robert Netzke
Robert Netzke
This would mirror the PSBT API. I don't see any problem with adding this.
Yeah I will look at this
1 doesn't feel like a great default to me. Reorgs of depth one happen all the time. I would go with 3, which to my knowledge has never occured, and...
It is non-intuitive to me to have `SyncProgress` be a collection of `usize` fields. It seems as though you can "consume" the SPK and still have the request fail? I...
From the [`secp256k1` docs](https://docs.rs/secp256k1/latest/secp256k1/): > For example, the library uses context objects that contain precomputation tables which are created on object construction... the tables are optional, giving a performance boost...
Thanks a lot for the thorough review. I will respond both high level and to review comments over the coming days.
> It also bothers me greatly that this can only seed pruned nodes - it limits its use a lot, it's hard to argue what this provides over current AssumeUTXO....
> found essentially no difference in the bitset encoding and using the run-length This turned out to not be true. Using bit-packing as shown in the current state of the...
> Are you intending to work on this P2P message? Is this part of any specification? Yeah I plan on creating a patch to add this, either here or separately....
Mind if I work on this? I'm not SOB but I am doing a similar program haha