Mark Integer::divides as deprecated.

Open aobatact opened this issue 4 years ago • 2 comments

Resolves #41.

Apr 28 '21 13:04 aobatact

Hey, congrats, you're the first contributor that I've had to manually approve for GitHub Actions. :/

But I expect this will fail on older Rust, since this crates tests all the way back to 1.8, and #[deprecated] wasn't stabilized until 1.9. It's also a required method (though it should probably forward to is_multiple_of), so the deprecation warning would be forced on everyone who implements the trait as well.

Apr 28 '21 23:04 cuviper

Sorry I didn't know that #[deprecated] can't be used in 1.8. So should we leave it until the min rust version is bumped? And should we make an fallback to is_multiple_of to make it as provided method?

Apr 29 '21 02:04 aobatact

We have since bumped to 1.31, and I just added the default fallback as you suggested.

Feb 08 '24 01:02 cuviper