ndarray icon indicating copy to clipboard operation
ndarray copied to clipboard

Implement product_axis

Open unrenormalizable opened this issue 2 years ago • 1 comments

product_axis is like sum_axis but for product. numpy has this implemented. it is the torch.prod equivalent with the dim argument. It will be good to have this implemented.

Some of the libraries I work with - mainly burn - is adding this functionality but i have to implement it for ndarray in the burn codebase.

unrenormalizable avatar Jan 24 '24 20:01 unrenormalizable

I think this is a good idea, since we have sum and sum_axis.

I was about to code it with fold_axis or map_axis, but it seems that we can use that function as a basis.

nilgoyette avatar Jan 25 '24 13:01 nilgoyette

Hello! Would love to continue contributing, and looking for some more low-hanging fruit; just submitted a PR to close this, please let me know if there's any feedback.

akern40 avatar May 18 '24 14:05 akern40