ndarray icon indicating copy to clipboard operation
ndarray copied to clipboard

Add optional support for borsh serialisation

Open Fuuzetsu opened this issue 2 years ago • 3 comments

Behind a feature flag.

Fuuzetsu avatar Nov 24 '23 07:11 Fuuzetsu

I don't know the opinion of the other maintainers, but I think we don't have much to lose since it's behind a feature gate.

Well, there is additional maintenance burden as presumably people that rely on this will expect it to work going forward.

If there's something I can do to try to proactively alleviate the concerns, let me know.

An alternative might be to implement this directly in borsh and push the burden in there but it gets much more convoluted this way due to versions and such. It might end up this way for chrono at least though: https://github.com/chronotope/chrono/pull/1366

Fuuzetsu avatar Nov 25 '23 12:11 Fuuzetsu

I addressed the couple of comments.

Fuuzetsu avatar Nov 27 '23 23:11 Fuuzetsu

Well, there is additional maintenance burden as presumably people that rely on this will expect it to work going forward.

Hum, right. I'm not the usual maintainer here and I hadn't thought about that :) The problem of ndarray in the last 2-3 years is the lack of maintainer. Because of this, I'm in no position to accept this MR. I'm not saying this will never get merged, but probably not by me.

nilgoyette avatar Dec 06 '23 02:12 nilgoyette