rust-ndarray
Change `NdProducer::Dim` of `axis_windows()` to `Ix1`
See #1304
This breaks the public API because the method axis_windows() now returns a new AxisWindows struct. And the dimension of the NdProducer::Dim will always be Ix1.
If the old behavior is needed the method windows() can be used.
I was thinking about adding a method AxisWindows::into_windows(self) -> Windows but I don't think that this will see much use. Let me know if i should implement it.
Is there anything holding this back that I can do do address?
The CI errors don't seem to be related to this PR.
Is there anything holding this back that I can do do address?
The CI errors don't seem to be related to this PR.
No. Sorry this is waiting on me finding time to look into it again.
Rebased and updated with rustfmt. Maintainer pushed to do that.
Oh, and I squashed everything together. I had to do that, conflict resolution (with rebase) is a bit tedious otherwise.
Thank you @jonasBoss and @adamreichold for the work on this one. It looks good to me, let's delay no further :slightly_smiling_face:, I'll be ready to push the merge button soon.