rustup icon indicating copy to clipboard operation
rustup copied to clipboard

Add automatic resume flag when retrying download with curl

Open darkkeh opened this issue 3 years ago • 1 comments

Should fix the resume issue that caused #2853 to be reopened.

Simply adds the resume flag -C and tells curl to automatically figure out where to resume the download with -.

darkkeh avatar Oct 12 '22 22:10 darkkeh

Sorry for being a bit slow to respond yesterday ended up being busy!

I did some manual testing by kill switching my network with my VPN (adding a video below to show the behavior). unknown.webm

I could look into adding an actual test case for this but I would probably need some guidance as I'm fairly new to rust and I wouldn't exactly be sure how to go about testing this properly

darkkeh avatar Oct 14 '22 21:10 darkkeh

I did some manual testing by kill switching my network with my VPN (adding a video below to show the behavior). unknown.webm

Looks good. Thank you!

I could look into adding an actual test case for this but I would probably need some guidance as I'm fairly new to rust and I wouldn't exactly be sure how to go about testing this properly

I don't think there's a way to test it in code, so manual testing is good enough.

0xPoe avatar Oct 19 '22 13:10 0xPoe

Sorry that it took a while again ended up being more busy than expected.

Added the check to verify that --continue-at is available and cleaned up some indentation

darkkeh avatar Oct 24 '22 04:10 darkkeh

There we go, commits have been squashed!

darkkeh avatar Oct 26 '22 19:10 darkkeh

Thanks again! 💚 💙 💜 💛 ❤️

0xPoe avatar Oct 27 '22 13:10 0xPoe