rustup icon indicating copy to clipboard operation
rustup copied to clipboard

Add `--profile empty` support

Open kinnison opened this issue 3 years ago • 4 comments

This is not necessarily the best way to do this, but I wanted an example up in case someone else wanted to take this further and complete it.

If @rbtcollins is OK with the idea of --profile empty and with this dodgy implementation then we can merge it, otherwise I'd rather this just be used to spark discussion.

If merged, this closes #2970

kinnison avatar Apr 01 '22 20:04 kinnison

Hi @kinnison. Can i try to continue to do this work? But i think your implemention is already OK. What can I do to make it more perfecter. Maybe some md should be update and should add some test like rustup toolchain install nightly --profile empty --component rustfmt to check the --component is still work.

likzn avatar May 07 '22 08:05 likzn

Functionally I think the change is complete. You are quite right that some documentation updates would be a good idea, along with augmenting the tests to verify install with empty profile and a component. I would like @rbtcollins to at least indicate he wouldn't veto this idea entirely though before we merge. If you want to have a go at the docs and additional test, then if you push a branch to your own fork of this branch, and then let me know, I'll pull them into mine so the PR updates.

kinnison avatar May 07 '22 08:05 kinnison

I have three concerns: are we solving a problem that no one has?

How much or how often will people get confused by the result of using this interesting option?

How usable is it for example a profile with just rustfmt... what does it actually do?

rbtcollins avatar May 07 '22 09:05 rbtcollins

To answer the first - currently noone has the problem, but this was discussed as an approach to provide rust-analyzer with a way to be distributed through default channels; but still permitting them to regularly update outside of the 6 week release train.

To the second - my hope is "very little" but we could put effort into hiding it a little more if you want. If we did that I'd like to hide complete too.

To the third, I cannot say for certain that all components would work without rustc or cargo available, but my expectation is that they'd at least give reasonable errors.

I'm happy to backburner this, it's not urgent in any sense.

kinnison avatar May 20 '22 10:05 kinnison