rustlings icon indicating copy to clipboard operation
rustlings copied to clipboard

install.sh checks for rustc and cargo but not rustup.

Open shaleh opened this issue 3 years ago • 5 comments

However, rustup is used at the end to install Clippy. While it is likely uncommon to end up with rustc and cargo but not rustup it is possible.

shaleh avatar May 16 '22 14:05 shaleh

It's quite possible to end up with rust and cargo without rustup. When you install it package manager like Homebrew or MacPorts, without rustup itself. I haven't checked numerious Linux distributions and FreeBSD, but my guess is the same

For me personally it even more preferrable way to don't install rustup itself if I have way to install rust via a package manager. In other words I don't trust binaries and shell scripts from the internet

eirnym avatar Jun 13 '23 09:06 eirnym

By the way, rust installation from distributions like mentionend above is one of recommended ways to install rust:

https://forge.rust-lang.org/infra/other-installation-methods.html

eirnym avatar Jun 14 '23 08:06 eirnym

The recommended way to install Rust has, and will likely always be rustup. I do agree that sometimes installing from distro package managers, or from source can be preferential, and I think we could probably provide an installation script flag to skip these rustup-specific checks.

manyinsects avatar Jun 14 '23 15:06 manyinsects

Please do. Rustling doesn't depend on nightly or other builds than stable. Tooling like clippy is important, and it's usually installed by a package manager

eirnym avatar Jun 21 '23 10:06 eirnym

Tooling like clippy is important, and it's usually installed by a package manager

Not quite true, the recommended way to install Clippy is via rustup component add clippy :) That doesn't detract from your point, though.

manyinsects avatar Jun 21 '23 11:06 manyinsects