rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard
verified publisher icon rust-lang

Issue 6202

Open CalebLItalien opened this issue 1 year ago • 2 comments

This closes #6202 .

CalebLItalien avatar Jun 30 '24 22:06 CalebLItalien

Apologies, was trying to squash the recent merge commit and accidentally reset the branch. This reopens the PR.

CalebLItalien avatar Jul 04 '24 00:07 CalebLItalien

The git history seems off to me. I think you might have squashed too many commits or grabbed the wrong commit message somehow?

ytmimi avatar Jul 04 '24 02:07 ytmimi

hey can I work on this issue

vatsalkeshav avatar Jan 31 '25 06:01 vatsalkeshav

@vats004 Sure! You can create a nearly identical PR. The only difference is that we'll need to gate this change on StyleEdition::Edition2027, instead of Version::Two.

ytmimi avatar Jan 31 '25 14:01 ytmimi

What's the rationale for gating a clear bugfix behind a future edition?

teohhanhui avatar Jan 31 '25 15:01 teohhanhui

What's the rationale for gating a clear bugfix behind a future edition?

rustfmt has a strong stability guarantee

ytmimi avatar Jan 31 '25 15:01 ytmimi

Closing since #6572 was merged instead

ytmimi avatar May 31 '25 15:05 ytmimi