rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

nightly convert `/// # })` to `//#### # })` in doc

Open LuckyTurtleDev opened this issue 2 years ago • 1 comments

cargo +nightly fmt make valid rust code invalid.

before:

    /// ```rust
    /// use scryfall::card::Card;
    /// use futures::stream::{self, StreamExt};
    /// use futures::future;
    /// assert!(
    /// # tokio_test::block_on(async {
    ///     Card::search("lightning").await
    ///         .unwrap()
    ///         .into_stream()
    ///         .map(Result::unwrap)
    ///         .all(|x| future::ready(x.name.to_lowercase().contains("lightning")))
    ///         .await
    /// # })
    /// )

after:

    /// ```rust
    /// use futures::future;
    /// use futures::stream::{self, StreamExt};
    /// use scryfall::card::Card;
    /// assert!(
    /// # tokio_test::block_on(async {
    ///     Card::search("lightning")
    ///         .await
    ///         .unwrap()
    ///         .into_stream()
    ///         .map(Result::unwrap)
    ///         .all(|x| future::ready(x.name.to_lowercase().contains("lightning")))
    ///         .await //#### # })
    /// )
    /// ```

Step to reproduce:

  • clone https://github.com/mendess/scryfall-rs
  • checkout commit bb5e151d3036a508db0a615cc3a4437de134f230
  • run cargo test, everything pass
  • run cargo +nightly fmt, some tests fails now

❯ cargo +nightly fmt --version rustfmt 1.7.0-nightly (62d7ed4 2024-01-11)

LuckyTurtleDev avatar Jan 12 '24 09:01 LuckyTurtleDev

looks like that is not the only issue. After fixing this manual even other tests fail:

---- search::tests::numeric_property_comparison stdout ----
thread 'search::tests::numeric_property_comparison' panicked at src/search.rs:397:9:
assertion `left == right` failed
  left: 0
 right: 2
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

LuckyTurtleDev avatar Jan 12 '24 09:01 LuckyTurtleDev