rust icon indicating copy to clipboard operation
rust copied to clipboard

Stabilize slice_split_at_unchecked

Open wutchzone opened this issue 2 years ago • 2 comments

Greetings!

I took the opportunity, and I tried to stabilize the slice_split_at_unchecked feature. I followed the guidelines, and I hope everything was done correctly :crossed_fingers: .

Closes #76014

wutchzone avatar Feb 02 '24 09:02 wutchzone

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Feb 02 '24 09:02 rustbot

@rustbot modify labels: +T-libs-api

wutchzone avatar Feb 02 '24 09:02 wutchzone

:umbrella: The latest upstream changes (presumably #120676) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Feb 09 '24 20:02 bors

This will need an FCP for stabilization. I have updated the tracking issue and nominated it for discussion.

m-ou-se avatar Feb 15 '24 12:02 m-ou-se

@m-ou-se (my apologies for pinging :pray:) The FCP stabilized this, do you think we can progress on this one, or are there any blockers?

wutchzone avatar Mar 23 '24 10:03 wutchzone

Thanks for the reminder!

@bors r+ rollup

m-ou-se avatar Mar 23 '24 10:03 m-ou-se

:pushpin: Commit 67c03579bc45a280548499d37ba2db7ef2e9f6a3 has been approved by m-ou-se

It is now in the queue for this repository.

bors avatar Mar 23 '24 10:03 bors