rust icon indicating copy to clipboard operation
rust copied to clipboard

fix verbatim with upstream dependencies

Open belovdv opened this issue 3 years ago • 11 comments

https://github.com/rust-lang/rust/issues/99425#issuecomment-1207224161

r? @petrochenkov

belovdv avatar Sep 14 '22 13:09 belovdv

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc_save_analysis v0.0.0 (/checkout/compiler/rustc_save_analysis)
error[E0382]: use of moved value: `formats`
   --> compiler/rustc_metadata/src/native_libs.rs:47:33
    |
36  |     let formats = if verbatim.unwrap_or(false) {
    |         ------- move occurs because `formats` has type `Vec<(Cow<'_, str>, Cow<'_, str>)>`, which does not implement the `Copy` trait
...
47  |         for (prefix, suffix) in formats {
    |                                 ^^^^^^^ `formats` moved due to this implicit call to `.into_iter()`, in previous iteration of loop
    |
note: this function takes ownership of the receiver `self`, which moves `formats`
    |
261 |     fn into_iter(self) -> Self::IntoIter;
    |                  ^^^^
    |                  ^^^^
help: consider iterating over a slice of the `Vec<(Cow<'_, str>, Cow<'_, str>)>`'s content to avoid moving into the `for` loop
    |
47  |         for (prefix, suffix) in &formats {

For more information about this error, try `rustc --explain E0382`.
error: could not compile `rustc_metadata` due to previous error
warning: build failed, waiting for other jobs to finish...

rust-log-analyzer avatar Sep 14 '22 14:09 rust-log-analyzer

@rustbot ready Current test is likely to fail on some architecture. Maybe forbid rollup?

belovdv avatar Sep 14 '22 15:09 belovdv

@bors r+ squash rollup=never

petrochenkov avatar Sep 14 '22 16:09 petrochenkov

:pushpin: Commit 68bff9b165479533eda358986fd5d10a87272ed5 has been approved by petrochenkov

It is now in the queue for this repository.

bors avatar Sep 14 '22 16:09 bors

:hourglass: Testing commit 68bff9b165479533eda358986fd5d10a87272ed5 with merge b4d89765aa70a0107cb80b553e6b164180160415...

bors avatar Sep 15 '22 02:09 bors

:broken_heart: Test failed - checks-actions

bors avatar Sep 15 '22 02:09 bors

The job dist-various-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [run-make] src/test/run-make/emit-shared-files ... ok
test [run-make] src/test/run-make/rustdoc-scrape-examples-ordering ... ok
test [run-make] src/test/run-make/rustdoc-scrape-examples-multiple ... ok
test [run-make] src/test/run-make/thumb-none-cortex-m ... ok
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-unknown-linux-gnu target=thumbv6m-none-eabi

failures:


---- [run-make] src/test/run-make/native-link-modifier-verbatim stdout ----
error: make failed
status: exit status: 2
command: "make"
--- stdout -------------------------------
--- stdout -------------------------------
# Verbatim allows specify precise name.
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  -Clinker='arm-none-eabi-gcc' local_native_dep.rs --crate-type=staticlib -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/local_some_strange_name.ext
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  -Clinker='arm-none-eabi-gcc' upstream_native_dep.rs --crate-type=staticlib -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/upstream_some_strange_name.ext
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  -Clinker='arm-none-eabi-gcc' rust_dep.rs -Zunstable-options -l static:+verbatim=upstream_some_strange_name.ext --crate-type rlib
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  -Clinker='arm-none-eabi-gcc' main.rs --extern rust_dep=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/librust_dep.rlib -Zunstable-options -l static:+verbatim=local_some_strange_name.ext
--- stderr -------------------------------
warning: ignoring --out-dir flag due to -o flag

warning: 1 warning emitted
warning: 1 warning emitted

warning: ignoring --out-dir flag due to -o flag

warning: 1 warning emitted

error: linking with `arm-none-eabi-gcc` failed: exit status: 1
  |
  = note: "arm-none-eabi-gcc" "-m64" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/rustc4R9ECf/symbols.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.1.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.2.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.3.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.4.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.4g86d6gt786od2ny.rcgu.o" "-Wl,--as-needed" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-l:local_some_strange_name.ext" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/librust_dep.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-bdaf92b78f291e95.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-e13cbb326bcd01a4.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libobject-13ac6af5403a52c8.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmemchr-a7b8febdd2acb289.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libaddr2line-343513f0726f71ed.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-8f833d900bfb98aa.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-e97a7960ca6216c8.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_detect-683fb35093a61fcc.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-f943c2d34bd4b56d.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libminiz_oxide-72ce2aaa649404e0.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libadler-ac5d08ad5339e92e.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-dacfda262d5656fb.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-e2056a834ba0712c.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-a60649c148c6e2db.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-3e961d059b9bcde7.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-20f26f875d0170e2.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-522518611024dce5.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-05898138a596088a.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-5b83a1df856cf582.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-znoexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main" "-Wl,--gc-sections" "-pie" "-Wl,-zrelro,-znow" "-nodefaultlibs"
  = note: arm-none-eabi-gcc: error: unrecognized command line option '-m64'

error: aborting due to previous error

make: *** [Makefile:8: all] Error 1

rust-log-analyzer avatar Sep 15 '22 03:09 rust-log-analyzer

The job dist-various-1 failed!

Looks like missing // ignore-cross-compile. @rustbot author

petrochenkov avatar Sep 15 '22 09:09 petrochenkov

@rustbot ready

belovdv avatar Sep 18 '22 08:09 belovdv

@bors r+ squash-

petrochenkov avatar Sep 18 '22 16:09 petrochenkov

:pushpin: Commit 0e44481b3e166bceb563dfbcbc367ed7e28af5ef has been approved by petrochenkov

It is now in the queue for this repository.

bors avatar Sep 18 '22 16:09 bors

:hourglass: Testing commit 0e44481b3e166bceb563dfbcbc367ed7e28af5ef with merge 1727154b169c1ed73092a6bbb411eaa31084e439...

bors avatar Sep 18 '22 22:09 bors

:broken_heart: Test failed - checks-actions

bors avatar Sep 19 '22 01:09 bors

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-apple-darwin target=x86_64-apple-darwin

failures:

---- [run-make] src/test/run-make/native-link-modifier-verbatim stdout ----
error: make failed
status: exit status: 2
command: "make"
--- stdout -------------------------------
--- stdout -------------------------------
# Verbatim allows specify precise name.
DYLD_LIBRARY_PATH="/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib:" '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc' --out-dir /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  local_native_dep.rs --crate-type=staticlib -o /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/local_some_strange_name.ext
DYLD_LIBRARY_PATH="/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib:" '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc' --out-dir /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  upstream_native_dep.rs --crate-type=staticlib -o /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/upstream_some_strange_name.ext
DYLD_LIBRARY_PATH="/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib:" '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc' --out-dir /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  rust_dep.rs -Zunstable-options -l static:+verbatim=upstream_some_strange_name.ext --crate-type rlib
DYLD_LIBRARY_PATH="/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim:/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib:" '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc' --out-dir /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim -L /Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim  main.rs --extern rust_dep=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/librust_dep.rlib -Zunstable-options -l static:+verbatim=local_some_strange_name.ext
--- stderr -------------------------------
warning: ignoring --out-dir flag due to -o flag

warning: 1 warning emitted
warning: 1 warning emitted

warning: ignoring --out-dir flag due to -o flag

warning: 1 warning emitted

error: linking with `cc` failed: exit status: 1
  |
  = note: "cc" "-arch" "x86_64" "-m64" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/rustchF9pET/symbols.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.0.rcgu.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.1.rcgu.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.2.rcgu.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.3.rcgu.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.main.cbcd4161-cgu.4.rcgu.o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main.4g86d6gt786od2ny.rcgu.o" "-L" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim" "-L" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "-l:local_some_strange_name.ext" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/librust_dep.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libstd-979692ae4164f81e.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind-79e874cd654f2fc1.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libobject-0ed715b6436420b4.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libmemchr-2a3458aa9a57f295.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libaddr2line-7e031a26ca5c58d8.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libgimli-b75302012caa1c87.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustc_demangle-31ccb5c837a11b32.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libstd_detect-0a2108798f897c54.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libcfg_if-b47e1d708a483a0f.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libhashbrown-4a01212bcda47f69.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libminiz_oxide-8a174673246627fc.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libadler-177316a513037c87.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustc_std_workspace_alloc-d7d1d839bed4bfcc.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libunwind-83ce42af47a6c33e.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libcfg_if-80a3ec77336a2861.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/liblibc-2c92e13fa6426441.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/liballoc-548b8428ebe27c01.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustc_std_workspace_core-7763b67623a38e07.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libcore-3775c6f0a76e9fa6.rlib" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-ab3ca315a35d8f42.rlib" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "-o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-make/native-link-modifier-verbatim/native-link-modifier-verbatim/main" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: ld: library not found for -l:local_some_strange_name.ext
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error

make: *** [all] Error 1

rust-log-analyzer avatar Sep 19 '22 01:09 rust-log-analyzer

@rustbot ready

belovdv avatar Sep 19 '22 08:09 belovdv

linker.rs doesn't currently add : correctly for verbatim modifiers, it should only add it to sess.target.linker_is_gnu linkers, other linkers (like macos linker from the CI failure) don't support it.

petrochenkov avatar Sep 19 '22 12:09 petrochenkov

@rustbot ready

belovdv avatar Sep 19 '22 13:09 belovdv

@bors r+ squash

petrochenkov avatar Sep 19 '22 14:09 petrochenkov

:pushpin: Commit f55797ca8661cb164a19a9516a7fe694565e246e has been approved by petrochenkov

It is now in the queue for this repository.

bors avatar Sep 19 '22 14:09 bors

:hourglass: Testing commit f55797ca8661cb164a19a9516a7fe694565e246e with merge 8fd6d03e22fba2930ad377b87299de6a37076074...

bors avatar Sep 20 '22 07:09 bors

:sunny: Test successful - checks-actions Approved by: petrochenkov Pushing 8fd6d03e22fba2930ad377b87299de6a37076074 to master...

bors avatar Sep 20 '22 09:09 bors

Finished benchmarking commit (8fd6d03e22fba2930ad377b87299de6a37076074): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.7% [5.1%, 6.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.4% [-5.4%, -5.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.1% [3.1%, 3.1%] 1

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

rust-timer avatar Sep 20 '22 12:09 rust-timer

@bors r+ squash

squash command works bad and shouldn't be used, probably: https://github.com/rust-lang/rust/commits?author=bors looks like one commit landed separately.

klensy avatar Sep 20 '22 14:09 klensy