Add new lint `paths_from_format`
Please write a short comment explaining your change (or "none" for internal only changes)
As per #8812
changelog: Add new lint [`path_from_format`]
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.
Please see the contribution instructions for more information.
:umbrella: The latest upstream changes (presumably #8882) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #8866) made this pull request unmergeable. Please resolve the merge conflicts.
Hey @merelymyself, welcome to the project!
r? @dswij (I'd appreciate it if you could leave a normal comment so that I can also assign you to this PR) :upside_down_face:
:umbrella: The latest upstream changes (presumably #8918) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #8916) made this pull request unmergeable. Please resolve the merge conflicts.
Could you do a rebase, not merge commit? We follow no merge-commit policy. https://github.com/rust-lang/rust-clippy/blob/master/doc/basics.md#pr
@giraffate , does this work?
Hi, @dswij. Made some changes, could you take another look? Thanks!
:umbrella: The latest upstream changes (presumably #8831) made this pull request unmergeable. Please resolve the merge conflicts.
Thanks for the patience and advice, @dswij. Could you take another look?
If there's a situation where a path like 'foo{}/bar' shows up, instead of offering a suggestion, a note is offered instead now.
:umbrella: The latest upstream changes (presumably #8964) made this pull request unmergeable. Please resolve the merge conflicts.
Once again, thanks for the patience and advice, @dswij! Do you mind taking another look? Besides the length thing, I think most of the suggestions have been resolved.
:umbrella: The latest upstream changes (presumably #9103) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9243) made this pull request unmergeable. Please resolve the merge conflicts.
Hi, @dswij. Again, thanks for all the help. Do you mind taking another look?
:umbrella: The latest upstream changes (presumably #9264) made this pull request unmergeable. Please resolve the merge conflicts.
@merelymyself Thanks for the changes! Sorry for the delay, I will try to get into it this week.
:umbrella: The latest upstream changes (presumably #9288) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9295) made this pull request unmergeable. Please resolve the merge conflicts.
Hi, @dswij . Sorry for the delay. Mind taking another look? Also, I renamed it to paths_from_format instead of path_from_formats because of the guidelines; "allow paths from format" makes more sense.
:umbrella: The latest upstream changes (presumably #9379) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9412) made this pull request unmergeable. Please resolve the merge conflicts.
btw, I'm not sure why the CI is red now - when I run cargo dev update_lints --check on my side no errors are thrown.
EDIT: ignore me, I just forgot to pull the new changes.
:umbrella: The latest upstream changes (presumably #9511) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9516) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9549) made this pull request unmergeable. Please resolve the merge conflicts.
:umbrella: The latest upstream changes (presumably #9658) made this pull request unmergeable. Please resolve the merge conflicts.
Hi, @dswij ! Sorry to disturb, but do you mind taking a look soon?
:umbrella: The latest upstream changes (presumably #9670) made this pull request unmergeable. Please resolve the merge conflicts.