rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Add new lint `paths_from_format`

Open merelymyself opened this issue 3 years ago • 23 comments

Please write a short comment explaining your change (or "none" for internal only changes)

As per #8812

changelog: Add new lint [`path_from_format`]

merelymyself avatar May 15 '22 07:05 merelymyself

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive avatar May 15 '22 07:05 rust-highfive

:umbrella: The latest upstream changes (presumably #8882) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar May 25 '22 01:05 bors

:umbrella: The latest upstream changes (presumably #8866) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar May 26 '22 05:05 bors

Hey @merelymyself, welcome to the project!

r? @dswij (I'd appreciate it if you could leave a normal comment so that I can also assign you to this PR) :upside_down_face:

xFrednet avatar May 27 '22 16:05 xFrednet

:umbrella: The latest upstream changes (presumably #8918) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar May 31 '22 05:05 bors

:umbrella: The latest upstream changes (presumably #8916) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar May 31 '22 18:05 bors

Could you do a rebase, not merge commit? We follow no merge-commit policy. https://github.com/rust-lang/rust-clippy/blob/master/doc/basics.md#pr

giraffate avatar Jun 01 '22 00:06 giraffate

@giraffate , does this work?

merelymyself avatar Jun 01 '22 04:06 merelymyself

Hi, @dswij. Made some changes, could you take another look? Thanks!

merelymyself avatar Jun 03 '22 07:06 merelymyself

:umbrella: The latest upstream changes (presumably #8831) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 03 '22 10:06 bors

Thanks for the patience and advice, @dswij. Could you take another look?

If there's a situation where a path like 'foo{}/bar' shows up, instead of offering a suggestion, a note is offered instead now.

merelymyself avatar Jun 09 '22 16:06 merelymyself

:umbrella: The latest upstream changes (presumably #8964) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 15 '22 06:06 bors

Once again, thanks for the patience and advice, @dswij! Do you mind taking another look? Besides the length thing, I think most of the suggestions have been resolved.

merelymyself avatar Jul 11 '22 12:07 merelymyself

:umbrella: The latest upstream changes (presumably #9103) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jul 15 '22 12:07 bors

:umbrella: The latest upstream changes (presumably #9243) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jul 25 '22 15:07 bors

Hi, @dswij. Again, thanks for all the help. Do you mind taking another look?

merelymyself avatar Aug 02 '22 06:08 merelymyself

:umbrella: The latest upstream changes (presumably #9264) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 02 '22 11:08 bors

@merelymyself Thanks for the changes! Sorry for the delay, I will try to get into it this week.

dswij avatar Aug 02 '22 14:08 dswij

:umbrella: The latest upstream changes (presumably #9288) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 09 '22 00:08 bors

:umbrella: The latest upstream changes (presumably #9295) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 19 '22 11:08 bors

Hi, @dswij . Sorry for the delay. Mind taking another look? Also, I renamed it to paths_from_format instead of path_from_formats because of the guidelines; "allow paths from format" makes more sense.

merelymyself avatar Aug 26 '22 07:08 merelymyself

:umbrella: The latest upstream changes (presumably #9379) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 26 '22 12:08 bors

:umbrella: The latest upstream changes (presumably #9412) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 01 '22 21:09 bors

btw, I'm not sure why the CI is red now - when I run cargo dev update_lints --check on my side no errors are thrown.

EDIT: ignore me, I just forgot to pull the new changes.

merelymyself avatar Sep 25 '22 09:09 merelymyself

:umbrella: The latest upstream changes (presumably #9511) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 27 '22 18:09 bors

:umbrella: The latest upstream changes (presumably #9516) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 29 '22 10:09 bors

:umbrella: The latest upstream changes (presumably #9549) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 03 '22 11:10 bors

:umbrella: The latest upstream changes (presumably #9658) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 16 '22 14:10 bors

Hi, @dswij ! Sorry to disturb, but do you mind taking a look soon?

merelymyself avatar Oct 16 '22 14:10 merelymyself

:umbrella: The latest upstream changes (presumably #9670) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 20 '22 15:10 bors