`redundant_closure` fixes

[Jarcho]

fixes #8548

A good chunk of the code is fixing false negatives. The old code banned any non late-bound regions from appearing in the callee's signature. The new version checks when the late-bound region is actually required.

changelog: Better track when a early-bound region appears when a late-bound region is required in redundant_closure. changelog: Don't lint redundant_closure when the closure gives explicit types.

[rust-highfive]

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

[Manishearth]

may not have time to get to this quickly, bouncing it over, feel free to bounce to someone else

[bors]

:umbrella: The latest upstream changes (presumably #8676) made this pull request unmergeable. Please resolve the merge conflicts.

[m-ou-se]

r? @flip1995

[flip1995]

I will be on $day_job vacation starting Saturday and then finally have time to go through my whole review queue over the weekend and next week :tada:

[bors]

:umbrella: The latest upstream changes (presumably #9447) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

ping @flip1995. Just a reminder this still exists.

[bors]

:umbrella: The latest upstream changes (presumably #10401) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

:umbrella: The latest upstream changes (presumably #10473) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

:umbrella: The latest upstream changes (presumably #10520) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

Since @flip1995 doesn't really have time.

r? @llogiq

[bors]

:umbrella: The latest upstream changes (presumably #11048) made this pull request unmergeable. Please resolve the merge conflicts.

[llogiq]

Took me a while to read through, but looks good to me. r=me with the conflicts fixed.

@bors delegate

[llogiq]

Oops, missed a plus sign.

@bors delegate+

[bors]

:v: @Jarcho, you can now approve this pull request!

If @llogiq told you to "r=me" after making some further change, please make that change, then do @bors r=@llogiq

[Jarcho]

The terrible diff probably didn't help much with that.

@bors r=@llogiq

[bors]

:pushpin: Commit 7423c2760b0dbfd4379d2c3eac309d660b859f41 has been approved by llogiq

It is now in the queue for this repository.

[bors]

:hourglass: Testing commit 7423c2760b0dbfd4379d2c3eac309d660b859f41 with merge 4c2f460dccf78b9f94df0a235de6ea10b0d495d3...

[bors]

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: llogiq Pushing 4c2f460dccf78b9f94df0a235de6ea10b0d495d3 to master...