rust-lang
Rename thread_local_initializer_can_be_made_const to missing_const_for_tl_init
Close #12934
As discussed at #12934 name thread_local_initializer_can_be_made_const sounds against convention for other lints which describe the issue/wrong code but not suggestion and it is quite long. The new name take example from existing lint missing_const_for_fn
changelog [thread_local_initializer_can_be_made_const] : Rename to missing_const_for_tl_init
r? @Alexendoo
rustbot has assigned @Alexendoo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
How about missing_const_for_thread_local? That it's a thread local is the important part of the name, I don't think we should abbreviate it
:umbrella: The latest upstream changes (presumably #13037) made this pull request unmergeable. Please resolve the merge conflicts.
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
You can start a rebase with the following commands:
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease
The following commits are merge commits:
- 885f97e2cefd1a246f47c6944afef5ffa6958426
- c17321b23d4fbec8bac32a70e8f1a2d4d4d8154d
- 0aac16e5b2b69e42347c9b783e87377b3a2d9608
:pushpin: Commit 6621e6cbfaddd39a7abeab92a30c7c6175184a6f has been approved by Alexendoo
It is now in the queue for this repository.
:hourglass: Testing commit 6621e6cbfaddd39a7abeab92a30c7c6175184a6f with merge 8919357587bfb6894efa908ede5f2c086eb7302c...
:hourglass: Testing commit 6621e6cbfaddd39a7abeab92a30c7c6175184a6f with merge 3ed690f07a93afd3ad1d5e9b109b0659490a4516...
:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: Alexendoo Pushing 3ed690f07a93afd3ad1d5e9b109b0659490a4516 to master...