rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard
verified publisher icon rust-lang

Add lint `manual_option_folding`

Open sjwang05 opened this issue 2 years ago • 6 comments

Closes #10646

This lint checks for panicking unwrap methods (unwrap, unwrap_unchecked, expect) used after get_or_insert_with.

changelog: new lint: [manual_option_folding]

sjwang05 avatar Sep 28 '23 20:09 sjwang05

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Sep 28 '23 20:09 rustbot

:umbrella: The latest upstream changes (presumably #11527) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 29 '23 03:09 bors

:umbrella: The latest upstream changes (presumably #11791) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 14 '23 16:11 bors

:umbrella: The latest upstream changes (presumably #11597) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Dec 01 '23 19:12 bors

Hey @sjwang05, sorry for the long wait. @giraffate is currently sadly busy and it went by unnoticed :see_no_evil:

Are you still interested in continuing this PR?

r? @xFrednet

xFrednet avatar Mar 31 '24 11:03 xFrednet

Sorry, I totally forgot about this PR, since it wasn't in my inbox anymore :see_no_evil: I'll add it to my todo list. You'll get a review next week!

xFrednet avatar Jun 20 '24 20:06 xFrednet

Hey @sjwang05, this is a ping from triage, since there hasn't been any activity in some time. Are you still planning to continue this implementation?

If you have any questions, you're always welcome to ask them in this PR or on Zulip.

@rustbot author

xFrednet avatar Jul 21 '24 09:07 xFrednet

Hey this is triage, I'm closing this due to inactivity. If you want to continue this implementation, you're welcome to create a new PR. Thank you for the time, you already put into this!

Interested parties are welcome to pick this implementation up as well :)

@rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review

xFrednet avatar Mar 16 '25 14:03 xFrednet