rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard
verified publisher icon rust-lang

fix: needless_range_loop's FP on the `Field` expr

Open kiscad opened this issue 2 years ago • 5 comments

Please write a short comment explaining your change (or "none" for internal only changes)

fix #11399

changelog: [needless_range_loop]: Fix the FP warning when the index-var is used in another "field" sequence.

kiscad avatar Aug 28 '23 11:08 kiscad

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Aug 28 '23 11:08 rustbot

r? @flip1995

kiscad avatar Aug 29 '23 01:08 kiscad

Hey, this is a ping from triage. @flip1995 can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@rustbot ready

xFrednet avatar Mar 29 '24 12:03 xFrednet

It looks like flip1995 is currently busy. Sorry for the delay, let's pick a new reviewer.

r? clippy

xFrednet avatar Jun 20 '24 20:06 xFrednet

So sorry that I didn't get to this. My comment here: https://github.com/rust-lang/rust-clippy/pull/11419#discussion_r1332746225 wasn't addressed yet. I think it's good that some other reviewer also takes a look at this. Maybe my understanding here is wrong.

flip1995 avatar Jun 21 '24 08:06 flip1995

Hey @kiscad, this is a ping from triage, since there hasn't been any activity in some time. Are you still planning to continue this implementation?

If you have any questions, you're always welcome to ask them in this PR or on Zulip.

@rustbot author

xFrednet avatar Jul 23 '24 06:07 xFrednet

No activity for more than one year.

samueltardieu avatar Aug 23 '25 22:08 samueltardieu