rust-analyzer icon indicating copy to clipboard operation
rust-analyzer copied to clipboard
verified publisher icon rust-lang

feat: Implement diagnostics for E0038

Open ShoyuVanilla opened this issue 1 year ago • 1 comments

As #17814 was merged, I think that E0038 can be implemented with ease

ShoyuVanilla avatar Aug 29 '24 17:08 ShoyuVanilla

@rustbot claim

ChayimFriedman2 avatar Aug 29 '24 20:08 ChayimFriedman2

This turned out not-so-easy since we currently have no infra for diagnostics in ty lowering...

ChayimFriedman2 avatar Aug 31 '24 23:08 ChayimFriedman2

This turned out not-so-easy since we currently have no infra for diagnostics in ty lowering...

Oops, you're right. I just remembered we have no such thing yet 😢

ShoyuVanilla avatar Sep 02 '24 01:09 ShoyuVanilla

@ShoyuVanilla I'm working on it, but it's a major change because of how ty lowering works.

ChayimFriedman2 avatar Sep 02 '24 14:09 ChayimFriedman2

First step (almost) complete: https://github.com/rust-lang/rust-analyzer/pull/18074.

ChayimFriedman2 avatar Sep 08 '24 20:09 ChayimFriedman2