rust-lang
minor : fixes for ratoml module
This is a follow-up PR to #17058.
- Parse errors are reflected as such by defining a new variant called
ConfigError::ParseError - Amend
config::ConfigChange::apply_change. - User config can be detected once again.
- New error collection has been added to store config level agnostic errors.
https://github.com/rust-lang/rust-analyzer/blob/bd9758bd5d780ab41068aa6e9c3ec0b3d3d593db/crates/rust-analyzer/src/config.rs#L3610-L3612
I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys.
:umbrella: The latest upstream changes (presumably #17488) made this pull request unmergeable. Please resolve the merge conflicts.
https://github.com/rust-lang/rust-analyzer/blob/bd9758bd5d780ab41068aa6e9c3ec0b3d3d593db/crates/rust-analyzer/src/config.rs#L3610-L3612
I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys.
Sprry forgot to reply to this. the error here is that sysroot isn't a table config, so the the non-table key being used here should error
:v: @alibektas, you can now approve this pull request!
If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril
:pushpin: Commit 784d46e8147d4a156ef00d963990db59a12799c9 has been approved by alibektas
It is now in the queue for this repository.
:hourglass: Testing commit 784d46e8147d4a156ef00d963990db59a12799c9 with merge 7507695a16eb9b17f24908e337677267d6f6d67d...
:sunny: Test successful - checks-actions Approved by: alibektas Pushing 7507695a16eb9b17f24908e337677267d6f6d67d to master...