rust-lang
Fixes tests on Solaris
Tested (libc-test) on both Solaris and Illumos (with latest stable Omnios). All tests are passing.
Illumos changes can be checked against https://github.com/illumos/illumos-gate Solaris changes can be checked only with installed Solaris CBE release (https://blogs.oracle.com/solaris/post/announcing-the-first-oracle-solaris-114-cbe) or using Solaris 11.4 machine at Cfarm (https://portal.cfarm.net/machines/list/).
r? @tgross35
rustbot has assigned @tgross35. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Could not assign reviewer from: tgross35.
User(s) tgross35 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.
@tgross can you please help me with the buildbot failure? I have no idea what is wrong and how can I fixt it...
Hi @psumbera! I think you meant @tgross35 (which is funny because @pfmooney and @jclulow who are at-mentioned here are old colleagues!) :grinning:
Not really my area of expertise at all but from context it looks like the epoll_event might be missing an implementation of the Debug trait?
@tgross can you please help me with the buildbot failure? I have no idea what is wrong and how can I fixt it...
I left a comment above but I think xrs_t may be missing implementations. If it can just go in s! to get the automatic derives, rather than s_no_extra_traits!, that is probably easiest. (I'm not actually sure why any of these types are in s_no_extra_traits! when their implementations look near identical to the derives, some of them could move to s!. We have a big cleanup of these traits coming in the near future.)
I'm not sure why FreeBSD failed but it looks spurious.
Are tests currently failing on these platforms? It would be great to add x86_64-unknown-illumos to CI since it is tier 2 with host tools.
@rustbot author based on the above comments. It would probably be good for @pfmooney to take another look at some point too.
Hi @psumbera! I think you meant @tgross35 (which is funny because @pfmooney and @jclulow who are at-mentioned here are old colleagues!) 😀
Out of all the similar GitHub usernames 😄 that really is an unbelievable coincidence
Not really my area of expertise at all but from context it looks like the
epoll_eventmight be missing an implementation of theDebugtrait?
Thanks for taking a look :) I think it's a different struct though (mentioned above), this crate is unfortunately pretty macro-heavy so the error messages are a bit obscure.
Hi @psumbera! I think you meant @tgross35 (which is funny because @pfmooney and @jclulow who are at-mentioned here are old colleagues!) 😀
Out of all the similar GitHub usernames 😄 that really is an unbelievable coincidence
Sorry about that!
@tgross35 can you please have another look?
Now it fails somewhere else and I don't know how to proceed again...
Sorry, slipped under my radar. I think the error is just saying that door_desc_t__d_data__d_desc needs to move to s_no_extra_traits! rather than s!, before a certain version somewhere in 1.6x you can't derive Debug on packed traits (I suspect you are just testing with a more recent rustc version locally).
Just comment @rustbot review to update the labels once it's working or if it gets stuck again.
:umbrella: The latest upstream changes (presumably #3867) made this pull request unmergeable. Please resolve the merge conflicts.
I think this looks okay but I am not able to test on the relevant systems. @pfmooney would you be able to double check this?
:umbrella: The latest upstream changes (presumably #3990) made this pull request unmergeable. Please resolve the merge conflicts.
Hm, not sure why freebsd is failing but it seems to be happening on everything
Hm, not sure why freebsd is failing but it seems to be happening on everything
Have no idea. Doesn't seem to be related.