libc icon indicating copy to clipboard operation
libc copied to clipboard

Fix CI by ignoring `rmx_state` on Apple platforms

Open joboet opened this issue 1 year ago • 1 comments

rmx_state has been removed in https://github.com/apple-oss-distributions/xnu/commit/94d3b452840153a99b38a3a9659680b2a006908e (macOS version 14.4) in favour of an expanded rmx_filler field. Just ignore it in CI.

joboet avatar Jul 18 '24 18:07 joboet

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jul 18 '24 18:07 rustbot

Oh, seems another failure appears.

JohnTitor avatar Jul 28 '24 13:07 JohnTitor

I think that's caused by rust-lang/rust#125834, which changed addr_of!(EXTERN_STATIC) to be safe.

joboet avatar Jul 29 '24 10:07 joboet