embedonomicon icon indicating copy to clipboard operation
embedonomicon copied to clipboard
verified publisher icon rust-embedded

Add triagebot configuration

Open LeSeulArtichaut opened this issue 5 years ago • 5 comments

This enables assignment through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

LeSeulArtichaut avatar Apr 13 '20 12:04 LeSeulArtichaut

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive avatar Apr 13 '20 12:04 rust-highfive

Build failed:

bors[bot] avatar Apr 14 '20 22:04 bors[bot]

Hey @jonas-schievink, this is complaining about a change in generated assembly code. Is this due to the "don't mangle the LR when panicking" change? Should we fix the expected generated ASM here?

jamesmunns avatar Apr 26 '20 17:04 jamesmunns

Looks like it, yeah

jonas-schievink avatar Apr 26 '20 17:04 jonas-schievink

Note: will probably need to be rebased on https://github.com/rust-embedded/embedonomicon/pull/66

jamesmunns avatar Apr 26 '20 18:04 jamesmunns