discovery icon indicating copy to clipboard operation
discovery copied to clipboard

Few suggestions after reading

Open leshow opened this issue 6 years ago • 0 comments

I finished the book. I really loved it, thank you so much for taking the time to write it, it was really fun trying some embedded programming for a change.

I have a few suggestions, you can close this issue if it's not the right place for it.

  • I'd like to know more how you found some of the information about the MCU from the reference manual. There's a few spots where you say how you gleaned the required information from the reference manual, it'd be nice to see more of that. For example, through the USART chapter I had no idea how you know to write to the TDR register, to check the ISR bit is clear to to know you can write to TDR.

  • in the i2c chapter I still don't get how the master-slave dance really works. I read the I2C section in the reference manual and I don't fully understand how you figured out what to do from it. I guess it's a bit of a skill you develop over time but it felt really opaque to me.

  • Some information on the structure svd2rust produces for crates like stm32f30x. It took a while for me to 'get' it. RegisterBlock closures for example, or what methods are available on which types; can I set_bit on this? Or does it only support read/write/modify?

  • Some stuff that was abstracted in init I'd like to know more about. Why do you need to constrain RCC or FLASH? Why split() the GPIOx registers?

leshow avatar Aug 11 '19 23:08 leshow