Add read_ep_address and make write_ep_address pub

Open thalesfragoso opened this issue 4 years ago • 3 comments

This make it possible to re-use this to write other serial drivers, like an async one...

https://github.com/akiles/embassy/pull/75

Mar 12 '21 21:03 thalesfragoso

Do you think it'd make sense to just go all the way and remove the read/write and such methods and just expose the entire endpoint objects via accessors or even pub fields? CdcAcmClass is meant to be used as a helper to implement other things anyways so hiding stuff probably isn't that important.

Also it'd be nice if global reformatting could be a separate commit so it's nicer to read :slightly_smiling_face: (I know the formatting is a mess right now, I can reformat it myself before next release)

Mar 15 '21 13:03 mvirkkunen

Although I don't need to go all the way right now, I agree with you, it makes sense to even have them as pub, do you think this should be in this PR ?

Sorry for the formatting, it was automatic... I can remove it.

Mar 17 '21 03:03 thalesfragoso

I like the idea of making the endpoints pub - ran in to the same issue in https://github.com/mvirkkunen/usbd-serial/issues/21

Jun 16 '21 03:06 ianrrees