human-panic icon indicating copy to clipboard operation
human-panic copied to clipboard

Fallback to repository if homepage is absent

Open Yamakaky opened this issue 4 years ago • 2 comments

Choose one: is this a 🙋 feature request

Expected Behavior

When the Cargo.toml parameter repository is present and homepage is absent, no URL is included in the message. If one wants to add the github URL, they need to set it in homepage. It's a bad practice since homepage is for a real home page, not a repository.

Current Behavior

repository is ignored.

Possible Solution

It would be nice to have a fallback to repository if homepage is absent. Or better, print both since they add different useful information.

Context

Code Sample

Your Environment

Software Version(s)
Package
Runtime
Package Manager
Operating System

Yamakaky avatar Aug 20 '21 19:08 Yamakaky

@epage is there a reason this has not been merged? I came here to inquire about this as well... Thank you for this awesome crate!

musselmandev avatar Nov 15 '24 06:11 musselmandev

Likely at the time, it was a breaking change and we were unready for it. Now, the PR has been stale for years.

I am open to homepage falling back to repository. I don't think we should show both, at least not with more information as to why. If someone is interested in that, they should create an issue specifically about the problem where showing both would be a solution.

epage avatar Nov 15 '24 22:11 epage