rust-cli
Adding `ron` support
This adds the feature flag ron_conf to confy which allows confy to work with ron files.
Note: I also set the rust language version in Cargo.toml to "2021".
I'm marking this as draft as I'm unsure how this affects versioning. Please let me know if there is anything I've missed or should correct :)
Hey thanks for doing this! I am okay with adding this since we compile out features we don't use. I left a couple comments to fix up other than that I'm happy to merge.
I'd love some tests if possible ❤️
Hi @deg4uss3r, thanks for the review and criticism. I realized that i kinda went out of scope changing some of the other things in this PR, I'll make sure to correct these things later today :)
I've made all of the requested changes and made sure that everything is working locally.
I added a test for checking that confy can deserialize into structs with a name different from the struct that was originally serialized (https://github.com/rust-cli/confy/pull/71/commits/381b3ff3ee3a702cff36bebfb07e56645a305b2d related) and all test pass when running cargo test --features ron_conf --no-default-features.
Not sure if I could test for anything else since all the other parts of the program work the same way they normally do.
@mWalrus These look great, thank you so much for making those changes!
All this looks good to me, if CI passes let's get this merged!
I'll also bump the edition in an MR then do a release.
Awesome, thanks for all the feedback! This was my first PR so it was slightly scary :sweat_smile:
No worries at all @mWalrus I hope this helped! If you have any questions just let me know :D