nom icon indicating copy to clipboard operation
nom copied to clipboard

Fix clamped capacity to be divided by element size

Open jkugelman opened this issue 3 years ago • 1 comments

Fixes https://github.com/Geal/nom/issues/1459#issuecomment-1244461213: the capacity of a Vec<O> is measured in number of elements not number of bytes, so divide 64KiB by the element size. This will round towards 0, which is desirable.

jkugelman avatar Sep 12 '22 23:09 jkugelman

Coverage Status

Coverage increased (+0.007%) to 79.285% when pulling 64216b897f572ff698950fb4c023f252d961f32d on jkugelman:clamp-capacity-wording into 3645656644e3ae5074b61cc57e3f62877ada9190 on Geal:main.

coveralls avatar Sep 12 '22 23:09 coveralls

Pull Request Test Coverage Report for Build 3796644783

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 61.637%

Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 1 81.02%
<!-- Total: 1
Totals Coverage Status
Change from base Build 3796631867: -0.01%
Covered Lines: 1499
Relevant Lines: 2432

💛 - Coveralls

coveralls avatar Dec 28 '22 21:12 coveralls

thanks!

Geal avatar Dec 28 '22 21:12 Geal