runrevmark

Results 68 comments of runrevmark

@montegoulding I take it the flush would be to ensure writes done by 'write to file' are immediate (so can be seen by other processes)? I guess this would be...

@livecodeian That is a very good point re update mode. Before changing the mechanism (I'll probably go for deferred error reporting) I'll double check whether GetFileSize is ever called when...

@livecodeian I think I've resolved the file size issue - it now computes the filesize as the max of (filesize + buffered-write-size) and (fileptr + buffered-write-size). I've also mitigated when...

@livecodeian Yes - you are correct - think I've amended that now :)

From a comment made by @montegoulding offline, I double checked the use of `Tell()` and `Seek()` when saving stackfiles. It turns out that `MCS_tell()` and `MCS_writeat()` are both used. Therefore...

I decided a modicum of caution was required here - so have split out the metrics caching into #7342. This needs a fair bit more work to be mergeable.

It doesn't as its orthogonal to the text encoding. Since LCS only understands (internally) numToChar(10) as an end-of-line, the text file line-ending conversion in LCS should really map all line-endings...

Yup - you're right - it does make sense to add an extra attribute to deal with line-endings. e.g. "file+utf8+eol:". (I was thinking in terms of reading files in, where...

@peter-b: Is this going to conflict with the Skia patch PRs?

It shouldn't lose it's integerness - for the number types if the fast path (using integers) fails it goes through the overflow path which produces an integer (unsigned rep if...