fladle icon indicating copy to clipboard operation
fladle copied to clipboard

Properties set at fladle scope don't get propagated to individual configs

Open valeraz opened this issue 4 years ago • 2 comments

When executing ./gradlew app:runFlankReleaseVariantTests from the configuration below, I noticed that orchestrator was still set to false (the default), despite the fact that it was set to true at the top-level scope:

fladle {
  useOrchestrator.set(true) // PROBLEM: not being propagated down
  configs {
    create("releaseVariantTests") {
      debugApk.set(project.provider { "$buildDir/outputs/apk/internal/release/$apkName" })
      instrumentationApk.set("$buildDir/outputs/apk/androidTest/internal/release/$testApkName")
      devices.set(listOf(mapOf("model" to "walleye" /* pixel2 */, "version" to "27"))) //
      testTargets.set(listOf("package slack.external"))
    }
  }
}

Running the fladle kotlin (sample)[https://github.com/runningcode/fladle/blob/master/sample-kotlin/build.gradle.kts] should repro this error.

valeraz avatar Mar 31 '21 21:03 valeraz

Thanks for the repro :D i should have noticed since its in this project. Will take a look!

runningcode avatar Apr 01 '21 07:04 runningcode

useOrchestrator property still doesn't propagate as expected for me. All other ones seem to work as expected.

valeraz avatar Apr 09 '21 18:04 valeraz