Nelson Osacky comments

Results 138 comments of


                                            Nelson Osacky

Builds from GitHub Actions Windows runners incorrectly tagged as `LOCAL`

Do you know what the change is that needs to be made here? I'm guessing this means that the `GITHUB_ACTIONS` environment variable is likely not able to be picked up...

The scripts should expose an option to increase the timeout

Hi @bmuschko, does editing `connect.timeout` or the `read.timeout` lines in the `network.settings` file help for this use case or are you asking for something else?

Build Scan capitalization appears consistent in user-facing text

Is this still something that needs to be done?

Update build dependency with the latest Variant API supported

@cdsap is there anything else we need to do here?

Update build dependency with the latest Variant API supported

Can you check if we still have usages of the Variant API?

Reducing high memory consumption

Hi @eugene-krivobokov thanks for bringing this up. I'm very open to ideas on how to improve this. I'm wondering, is the memory still retained after a single build completes? At...

Run screenshot tests using Shot plugin or Facebook plugin

Aside from Fladle do they have documentation on how to run those tests on firebase test lab? Are they compatible with that? If so I can find a way to...

Configuration cache issues with this plugin when benchmarking remote cache

Thanks for reporting. This will need to be reworked. I'm open to PRs. In the meantime, can you disable configuration cache for workflows that use the benchmark?

Update JavaGCFlagChecker to recommend G1GC for Java 17+

Thanks @NickFirmani do you have any benchmarks or information on in which scenarios G1GC is faster?

Update JavaGCFlagChecker to recommend G1GC for Java 17+

This article seems to suggest that the parallel GC still gives the best performance: https://dev.to/cdsap/using-parellgc-for-the-kotlin-process-in-android-builds-2geh