finch icon indicating copy to clipboard operation
finch copied to clipboard

finch attach not available as top level command

Open weikequ opened this issue 2 years ago • 2 comments

Describe the bug Finch should make finch attach available as a top level command to keep parity with nerdctl. It is currently available as a subcommand as finch container attach

Steps to reproduce

  • finch attach --help

Expected behavior

$ finch attach --help
Attach stdin, stdout, and stderr to a running container. For example:

Screenshots or logs

  • FATA[0000] unknown command "attach" for "finch"

weikequ avatar Jan 03 '24 18:01 weikequ

Hi, Team Could you assign this issue to me ? I'll address this issue.

haytok avatar Mar 08 '24 03:03 haytok

This feature can be added, but we can't implement the test because of a bug in nerdctl.

  • https://github.com/containerd/nerdctl/issues/2877
  • https://github.com/containerd/containerd/pull/10020

Further details are discussed at a below PR.

  • https://github.com/runfinch/finch/pull/847

haytok avatar May 13 '24 13:05 haytok