plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

[New Plugin] - What Pet is that Anyway - v1.0.0 - Sololegends

Open sololegends opened this issue 1 year ago • 6 comments

What Pet is that Anyway

Adds an on-hover tooltip for everyone's !pets command so you can see what the heck those little icons actually are.

sololegends avatar Oct 13 '24 23:10 sololegends

New plugin what-pet-is-that-anyway: https://github.com/sololegends/runelite-what-pet-is-that-anyway/tree/309aca315c97835ac1372ba5d9448ad786ac0de3

This seems like a good contribution to core if you have not already PR'd it there.

LlemonDuck avatar Oct 15 '24 03:10 LlemonDuck

I was going to, but it seemed some build reqs locked behind a repo I didn't have access to.

sololegends avatar Oct 15 '24 11:10 sololegends

The core client can be built just fine off the runelite/runelite repository.

https://github.com/runelite/runelite/wiki/Developer-Guide

LlemonDuck avatar Oct 15 '24 21:10 LlemonDuck

I'll try to work through it again, I went through that doc and during the maven build it tried to access a maven repo which kept returning a 403.

Alright having different build issues now so that is something.. I'l work through it and get it into the core client

sololegends avatar Oct 16 '24 13:10 sololegends

Submitted a pr with this just in the chat commands core plugin

https://github.com/runelite/runelite/pull/18442

sololegends avatar Oct 16 '24 16:10 sololegends

@sololegends We can go ahead and merge the hub plugin version here for now if you want to pull your recent changes back over, and if the core PR gets renewed attention later then that can be separate.

LlemonDuck avatar Nov 12 '24 03:11 LlemonDuck

Aight, I'll get the updates synced over here as soon as I can

sololegends avatar Nov 12 '24 03:11 sololegends

Can you remove your changes to the build.gradle? Do you really need to publish it to a maven repo?

As for building a custom JAR, you can use the shadowJar configuration from the template plugin instead of copying your test file into sources: https://github.com/runelite/plugin-hub/blob/master/templateplugin/build.gradle

LlemonDuck avatar Nov 20 '24 05:11 LlemonDuck

I publish every jar by ci to a central repo I control as an easy way for me to pull down whatever I need easily. I do this for every project I create.

I'll rip it out tomorrow, I'll just have a different upstream.

sololegends avatar Nov 20 '24 08:11 sololegends

You can already do that with an action you make on your repository

raiyni avatar Nov 20 '24 13:11 raiyni