plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Update Global Chat

Open RusseII opened this issue 1 year ago • 4 comments

Fixes the security issues that resulted in plugin getting disabled in https://github.com/runelite/plugin-hub/commit/9f331caab55f672ad96ea8d69e55d33bae08da57 CleanShot 2024-07-31 at 11 59 31@2x

  1. This is exfiltrating all dms to a channel anyone can subscribe

CleanShot 2024-07-31 at 11 42 58@2x

  1. allows spoofing messages with the mod crowns.

  • Fixed by only allowing ironman icons with the new and getValidAccountIcon and isInvalidUsername function

RusseII avatar Jul 31 '24 15:07 RusseII

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

LlemonDuck avatar Oct 15 '24 03:10 LlemonDuck

Thanks @LlemonDuck. Added your suggestions

RusseII avatar Oct 19 '24 23:10 RusseII