plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create gim-buddy

Open fNudz opened this issue 1 year ago • 6 comments

Created gim-buddy

fNudz avatar Jul 19 '24 03:07 fNudz

New plugin gim-buddy: https://github.com/fNudz/gim-buddy/tree/70ff84b48b3b337bbe9d48cbfda0ec7b35047221

@GarrettJhnsn https://github.com/runelite/plugin-hub/pull/6330#issuecomment-2238010494

YvesW avatar Jul 19 '24 03:07 YvesW

ImageIO.read(new File("src/main/resources/icon.png")) would not work in production as explained here: https://github.com/runelite/plugin-hub?tab=readme-ov-file#plugin-resources

(you should switch to ImageUtil.loadImageResource)

iProdigy avatar Jul 20 '24 05:07 iProdigy

You should gitignore the bin/ folder which appears to contain the compiled project (which isn't the default gradle build location, so I'm not sure how you ended up with it there anyway)

Make sure you also remove it after adding it to the gitignore

git rm -rf --cached bin

LlemonDuck avatar Jul 29 '24 17:07 LlemonDuck

I think you need to add a warning like this since it's possible to configure the plugin to send data outside your computer.

Unmoon avatar Sep 19 '24 06:09 Unmoon

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

MESLewis avatar Oct 03 '24 15:10 MESLewis

closing as the above comments have not been resolved yet. feel free to resubmit when they are

LlemonDuck avatar Nov 12 '24 03:11 LlemonDuck