The undo button is too far from reset button

[xnuk]

Related repository: TinyWebEx/AutomaticSettings

Bug description

https://github.com/rugk/offline-qr-code/assets/3071003/e09491e2-d549-4b27-82db-3f91313bd7de

Let's say I made a mistake that I accidentally pressed the reset button. I expected some confirmation UI appears, but there was nothing. So I have to undoing options manually from my memory, and while doing it, I find there is actually 'Undo' button at the top of the settings page.

Steps to reproduce

1. In the settings page, click 'Reset all settings to defaults'
2. No confirmations or undo buttons is shown right at that moment
3. Panic

Expected behavior

An undo button or a reset confirmation should be in visible area at that moment, right after clicked the reset button.

Possible solution

I think replacing reset button to 'Undo' would be great, like clicking

[[ Reset all ]]

is replaced to

✔️ All are reset [[ Undo ]]

.

Or putting the toast message at the bottom is also okay I think?

[rugk]

That is a great idea and indeed a UX flaw. As you noticed, it needs to (or rather should) be implemented in https://github.com/TinyWebEx/AutomaticSettings/

Contributions are very welcome. I've also created an issue there to track it with more details of what I'd do implementation-wise: https://github.com/TinyWebEx/AutomaticSettings/issues/28

[renji18]

Hey @rugk, I'd like to work on this issue as I start my contribution into open source.

[rugk]

Okay, great, please see what I've wrote before, that should give you the correct direction.

[TImmykiller5]

Can I still work on this?

[rugk]

As I saw @renji18 removed their assignment, I take this as a you for you @TImmykiller5. Anyway, feel free to work together/communicate here if something needs to be done etc.

So yeah, sure, you can take it. And thanks a lot in advance. If you have any issues or questions, e.g. how to implement a certain thing or how a thing works, feel free to ask. Also note GitHub's help can help on topics on how to use GitHub and e.g. how to create and update pull requests. Please also read our contributing guide to see how to get started with development and help us. And please read the past communication in this issue ans PRs to see what still needs to be done.

[Hamjaster]

I see this issue is still open, I'd like to work on it, I'd place the UNDO button aside reset button, and make it look good

Thanks in advance :)

[rugk]

Okay, there is already a PR at https://github.com/rugk/offline-qr-code/pull/312, please have a look at it if it works out. I assume, if help is needed, @renji18 you can jump in and you may work together. Please note as you can see there, this should be solved for all extensions using the https://github.com/TinyWebEx libraries.

[Hamjaster]

I don't understand what you mean by " it should work on all extensions"?? And the github repo link you're giving?

Isnt it just a small css layout fix?

[xnuk]

@Hamjaster As you can see you're now the 3rd assignee of this issue - previously two person stucked for resolving this. Personally I don't think this is a good first issue label though.

Isnt it just a small css layout fix?

This would be fixed by small javascript and css, if this project has simple enough structure. My first saw was, it isn't. The UI I referred in issue description depends on TinyWebEx libraries and it's little bit hard-coded - non-configurable for solving this issue. So... good luck?

[rugk]

Personally I don't think this is a good first issue label though.

Oh yeah, nowadays, I agree, let's better remove it. It is indeed somewhat difficult.

The UI I referred in issue description depends on TinyWebEx libraries and it's little bit hard-coded

I am always open for improvements, at best as PRs.