offline-qr-code icon indicating copy to clipboard operation
offline-qr-code copied to clipboard

Updates screenshots and screencaps for new Firefox design

Open dialectrical opened this issue 4 years ago • 5 comments

Includes updated screenshots and screencaps for the new Firefox design.

Addresses issue #268

dialectrical avatar Sep 02 '21 21:09 dialectrical

FYI, BTW, you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.)

rugk avatar Sep 03 '21 19:09 rugk

Just to clarify, you're saying screenshots should look similar to the qrSmall.png screenshot I included, right? In that, they should show the Offline QR Code button on Firefox in the frame?

dialectrical avatar Sep 03 '21 20:09 dialectrical

Yeah, that's what I mean. Just also add some padding around that thing (you don't need to crop it too exactly, it looks more "natural" if one also sees other buttons and the hamburger button/part of the address bar of Firefox e.g. - so one sees where that image is taken from) and you can vary (or just use the same as I did) with the colored icon option, to demonstrate that the icon can be black/white and also colored. (IMHO in that dark mode, the colored icon is actually less readable, so I'd tend to more screenshots with the non-colored icon.)

rugk avatar Sep 03 '21 21:09 rugk

@dialectrical If you need any pointers/help or have questions, feel free to ask.

rugk avatar Nov 20 '21 17:11 rugk

@dialectrical Are you still interested in completing this? If not, that's no problem, just add a notice, so I know what the current status of this PR is.

rugk avatar Jan 02 '22 16:01 rugk