playtime icon indicating copy to clipboard operation
playtime copied to clipboard

Refactor views/styles

Open leesharma opened this issue 8 years ago • 5 comments

Another open-ended Hacktoberfest issue. 🎃

There are some places where the styles spill into the views or are a little messy (for example, we have some <br />s scattered around). Improving this should make the app a little easier to maintain.

Some examples of fixes in this category:

  • Moving things related to page style/layout (ex. stray <br>s) from the views to the stylesheets
  • Removing redundant/unused styles from the stylesheets
  • Adding helpful comments

If you want to do any major reorganization or make changes to the UI, let us know before you get started. We wouldn't want you to put a lot of effort into something we're not going to merge!

leesharma avatar Oct 07 '17 21:10 leesharma

I can take a look at this if you are still wanting someone to help out!

IanEarley avatar Oct 09 '17 21:10 IanEarley

@IanEarley Sure thing! 😄 Let us know if you have questions or want feedback on what you're doing!

leesharma avatar Oct 10 '17 23:10 leesharma

I did some br tag cleanup in https://github.com/rubyforgood/playtime/pull/121

invacuo avatar Oct 11 '17 03:10 invacuo

Do you still need anymore help with this?

ritarenee15 avatar Oct 25 '17 23:10 ritarenee15

@ritarenee15 Definitely! We don't have specific tasks for this one; it's more of a general clean-up issue. If you see something custom that could be expressed with Boostrap classes, messy view code that could be cleaned up, or whatever else, open a PR! 😄

If you want something more concrete, I also just opened an issue relating to a UX bug: #172.

leesharma avatar Oct 26 '17 03:10 leesharma