playtime icon indicating copy to clipboard operation
playtime copied to clipboard

Add Facebook share button

Open leesharma opened this issue 8 years ago • 6 comments

Continuation of #107

The Facebook social share button wasn't working, so we decided to remove it for the first release. Now that development is a little more leisurely, we should add it back and get it working.

leesharma avatar Oct 02 '17 01:10 leesharma

I never actually asked: @Brennaleker, do you want to be assigned to this?

leesharma avatar Oct 13 '17 20:10 leesharma

I've gone ahead and unassigned this for visibility. For the current implementation their is an existing issue with SocialShareButton. Another option would be to use a different dependency or custom JS for Facebook only.

Brennaleker avatar Oct 15 '17 18:10 Brennaleker

hey, is this issue solved as I have checked the website and facebook share button has worked there for me

grvsachdeva avatar Oct 16 '17 19:10 grvsachdeva

@Gauravano Yep, this is still open! The website you're looking at is the playtime homepage, not this app. We don't have a production version of this up yet, but the staging version can be found here.

The share buttons appear on the wishlists. This task is to add the facebook button and make it work. That probably will require whitelisting the staging url somewhere; the socialsharebutton gem probably has some documentation on how to do that.

Alternatively, if the issue's with the gem itself, it may be worth getting rid of the dependency and adding the share buttons manually.

Are you interested in taking this issue on?

leesharma avatar Oct 16 '17 20:10 leesharma

Yes, I want to try I will first use social-share-button gem if this doesn't work then I'll try another method.

grvsachdeva avatar Oct 16 '17 20:10 grvsachdeva

Awesome! 🎉 Let us know if you have any questions.

leesharma avatar Oct 16 '17 20:10 leesharma