pet-rescue icon indicating copy to clipboard operation
pet-rescue copied to clipboard

Rename Task to Checklist::TaskAssignment

Open kasugaijin opened this issue 1 year ago • 6 comments

Task should be renamed to Checklist::TaskAssignment. This means renaming all areas in the app (table (tasks), model, controller, policies, views, tests, variables, methods etc.). It should be a relatively straightforward find and replace.

Note the table should be renamed to task_assignments_table. The Checklist scope helps to organize this resource along with others that are similar.

please nest the classes instead of inline: https://thoughtbot.com/blog/why-you-should-nest-modules-in-ruby we are trying to move to the nested format throughout.

Any questions - comment below!

kasugaijin avatar Jun 15 '24 02:06 kasugaijin

Can I work on this?

wandergithub avatar Jun 15 '24 03:06 wandergithub

@wandergithub yup!

kasugaijin avatar Jun 15 '24 03:06 kasugaijin

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 16 '24 00:07 github-actions[bot]

@wandergithub it looks like this has sat for a while, which is fine. We decided we are going to go to MVP using the existing Default Pet Task model and Task model, so this issue can actually sit until later. I am not sure if you have worked on it or not. If you have, you can push a draft PR so we have the work on remote. If not, that's fine, we can unassign you and revisit this when we are ready.

kasugaijin avatar Jul 21 '24 23:07 kasugaijin

I did start but was facing some errors/setbacks... It is most likely something I don't understand and I messed up. For now, I've been dealing with life so it is okay if you unassing me. I will get back to it when I have time.

wandergithub avatar Jul 22 '24 16:07 wandergithub

@wandergithub ok no worries at all! I have unassigned you and placed this on hold for when we are ready to tackle this refactor after launch.

kasugaijin avatar Jul 22 '24 18:07 kasugaijin