pet-rescue icon indicating copy to clipboard operation
pet-rescue copied to clipboard
verified publisher icon rubyforgood

Refactor code related to adopter foster profile in seed files using lambda

Open atbalaji opened this issue 1 year ago • 4 comments

  • To avoid code redundancy for adopter_foster_profile params rewrite them using lambda
  • Refer the recently added implementation using lambda for any doubts

atbalaji avatar May 16 '24 05:05 atbalaji

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 09 '24 00:07 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jul 16 '24 00:07 github-actions[bot]

Hi, I would like to work on this issue. Do you have any specific details on which files/where specifically on the code redundancy? I saw the adopter_foster_profile_helper.rb file but I'm not seeing any repetitive code, so I want to clarify what you're referring to. (sorry, I'm trying to contribute to an open source project for a class and might need a little bit of help getting started)

felicia22 avatar Sep 24 '24 18:09 felicia22

Hey @felicia22! I think this task is outdated and could probably be closed. Looking at this seed file from a PR submitted right before this issue was opened, we can get an idea of what this issue was probably asking for.

But considering the model AdopterFosterProfile has been renamed/dropped and the db/seeds/* file structure no longer looks similar, I'm not sure if this is necessary any longer.

coalest avatar Oct 08 '24 14:10 coalest