pet-rescue icon indicating copy to clipboard operation
pet-rescue copied to clipboard

Display feature pets on org home page [558]

Open VonTeacher opened this issue 1 year ago • 8 comments

🔗 Issue

Display feature pets on org home page #558

✍️ Description

  • [x] Created instance variable in the Organizations::HomeController#index action to sample from the adoptable_pets (though I'm not sure the pattern matches what is used in other controllers).
  • [x] Replaced four static pet cards on the /<org>/home page with a sample of the adoptable pets from that organization.

📷 Screenshots/Demos

Before:

image

After:

Screen Shot 2024-04-11 at 17 59 11

VonTeacher avatar Apr 21 '24 05:04 VonTeacher

FYI tests failures and need to run the linter.

kasugaijin avatar Apr 22 '24 17:04 kasugaijin

@all-contributors please add @VonTeacher for code.

kasugaijin avatar Apr 22 '24 21:04 kasugaijin

@kasugaijin

I've put up a pull request to add @VonTeacher! :tada:

allcontributors[bot] avatar Apr 22 '24 21:04 allcontributors[bot]

@VonTeacher let me know if you have any questions!

kasugaijin avatar Apr 27 '24 16:04 kasugaijin

@VonTeacher hey are you still able to finish this? Please let me know in the next couple of days. I usually re-assign issues that sit without communication for a week or more. Thanks :)

kasugaijin avatar May 03 '24 22:05 kasugaijin

Thanks for the reminder and apologies for the delay. I'll spend some time ~this weekend~ now.

Edit: I updated the test file, taking into account your comments on the script and resolving conflicts that occurred as a result of #618. Awaiting workflow approval and any other comments you might have had on the home#index method.

VonTeacher avatar May 03 '24 22:05 VonTeacher

@VonTeacher No worries at all! Just making sure you have what you need and still able to work on it.

kasugaijin avatar May 05 '24 18:05 kasugaijin

@VonTeacher let me know if you can update re my feedback above. If not, I can also finish this off if you're busy. Let me know :)

kasugaijin avatar May 11 '24 19:05 kasugaijin

@kasugaijin (and @VonTeacher) might we want to merge this PR this weekend?

maebeale avatar May 31 '24 14:05 maebeale

@maebeale yes we can it just needs the tests removing or updating. I personally don’t think m this needs to be tested.

kasugaijin avatar May 31 '24 14:05 kasugaijin

Resolved by #784

meg-gutshall avatar Jun 01 '24 19:06 meg-gutshall