human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Picklists should be filterable

Open cielf opened this issue 1 year ago • 7 comments

Summary

The print picklists function for request should be filterable

Why

Allow banks to print only a subset of the picklists - for example, for a particular partner, or partners that got their requests in before a deadline for preferential handling. Right now it's all or nothing (we don't even allow a single picklist)

Details

To see what we're talking about:

sign in as [email protected] click Requests There is a "Print Unfulfilled Picklists" button. This currently prints all the unfulfilled requests as picklists, regardless of the filtering.

What we want

That button should print picklists for the filtered requests. The number of requests on the button should also match the filtered requests.

Note:

The request export does filter properly -- that might be some help in figuring this one out.

Criteria for completion

  • [ ] behaviour as described above
  • [ ] tests to confirm behaviour
  • [ ] Update to user documentation. docs/user_guide/bank/essentials_requests.md

cielf avatar Feb 02 '25 16:02 cielf

Will be attempting this as part of the SCALE 2025 workshop.

joepaolicelli avatar Mar 06 '25 19:03 joepaolicelli

Excellent!

cielf avatar Mar 06 '25 20:03 cielf

I have a fix that appears to work here. I'll spend a little more time testing it, and try and write some tests for it, sometime during the next week.

joepaolicelli avatar Mar 06 '25 20:03 joepaolicelli

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Apr 07 '25 00:04 github-actions[bot]

Hey @joepaolicelli -- still looking to see the PR from your changes for this.

cielf avatar Apr 07 '25 00:04 cielf

PR #5148 opened! Thanks for your patience!

joepaolicelli avatar Apr 10 '25 15:04 joepaolicelli

Re "Help Wanting" this. It needs PDF testing savvy that @joepaolicelli doesn't have. Please see his PR as a starting point.

cielf avatar May 03 '25 01:05 cielf