rubyforgood
case insensitive sorts throughout
Summary
All the alphabetical sorts (in drop downs, indices, exports, and reports) should be in natural alphabetical order (aka case insensitive alphabetical order)
Why?
It's the human way of doing things
Details
The 'natural' and computer-based alphabetizing are not the same --- so there are a bunch of surnames that would be out of order, for example -- (the ones beginning with de or van for example ). As well, if someone enters a new item in lowercase, it would be out of order in various dropdowns
Survey and repair all the sorts.
Please keep an eye out for sorts that are still in order-added order -- call those out, but we're pretty sure they should be natural alpha as well.
Consider adding shared helpers (if it makes sense).
Note: This will require communication to the users if any exports are involved.
Criteria for completion
- [ ] all sorts are in human alphabetical order
- [ ] Tests to support
- [ ] May need some light work on the user guide to point out the new orders
Note:
Double-check we don't already have exactly this one.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kellis5137 - Sure! Please feel free to put in pull requests that partially fix it -- it's a pretty wide spread thing. Also, if/when you work with exports, make a special note that we need to do some special communication to our users.
@cielf Can you give me an example where this is happening? I'm just trying to find one example in my dev environment, but I'm pretty sure the test data is pretty basic. I just want an example so I can see the code/app doing it!
@cielf Can you give me an example where this is happening? I'm just trying to find one example in my dev environment, but I'm pretty sure the test data is pretty basic. I just want an example so I can see the code/app doing it!
Never mind, I found something
(nods) I think we have it fixed in a few cases, but the idea of the issue is to make it consistent throughout.
@cielf Got a little busy, but back on this... I just uploaded my a single fix and test. It's been a while since I did Ruby and RSpec. It's really simple, but could someone take a look at both just to see if I'm missing something? Before I start doing a whole bunch that way. :-)
https://github.com/kellis5137/human-essentials/blob/0999e16e95f36d77e849072bd57b9d9ab9664970/app/controllers/admin/users_controller.rb#L68
https://github.com/kellis5137/human-essentials/blob/0999e16e95f36d77e849072bd57b9d9ab9664970/spec/system/admin/users_system_spec.rb#L171
Hey @kellis5137 Could you, please, submit it as a PR , and just indicate that it is a partial resolution of this issue.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.