Product totals - custom units

[awwaiid]

Implement #4408

• Adds units when feature is enabled and there are any units
• Changes sort to be by name instead of by qty

[awwaiid]

I'm wondering which is better, Pads - units or Pads. Also ... the way we've implemented units elsewhere end up recording an empty string. We could maybe explicitly record "units" as the individual-units default recorded in the database.

[cielf]

Which is better is a fair question. Is it a Wednesday question?

[dorner]

I'd probably prefer it like this:

• Pads (individual)
• Pads (in packs)

[cielf]

I'd probably prefer it like this:

• Pads (individual)
• Pads (in packs)

I think (in packs) implies the number of pads that happen to be in packs, as opposed to the number of packs. I kind of like the parentheses, though.

This is still the whole naming things issue - but I think we should be consistent between what we use for the partners and what we use for the banks -- because they do have conversations.

How about:

• Pads (units)
• Pads (packs)

I don't like "units", because of the naming conflict with "Custom Request Units" , but it's what we got from the banks. We could check if "pieces" would work for them, maybe?

[awwaiid]

From our discussion on the call today, this is now updated to use plural when units are specified and blank otherwise.

[awwaiid]

Two wee things: 1/ The sort should be lower-case alpha. (we are standardizing on that) 2/ If we're not showing the unit, we shouldn't show the dash either, methinks.

Fixed!

[github-actions[bot]]

@awwaiid: Your PR Product totals - custom units is part of today's Human Essentials production release: 2024.11.24. Thank you very much for your contribution!