human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Bank Org Request Export - Include Custom Units

Open awwaiid opened this issue 1 year ago • 2 comments

Implements #4405, adding custom units to request export.

  • This does not change the general output, which only includes items that are part of some exported request
  • If any item is configured to have custom units, we now include a column for each custom unit and no-unit, whether any requests made use of those or not
  • Also, if the item's custom-unit was deleted but it is referenced, go ahead and add a column for it anyway
  • Significantly dumbed down the corresponding spec

awwaiid avatar Aug 24 '24 22:08 awwaiid

Hrm. I did an export that looked clean, but then I added a request that just had pads with 233 units. I got a "no implicit conversion from nil to integer" on line 99 of export_request_service. (Note: I made partner group 1 have all the categories, and gave pads a category of Period Supplies first).

cielf avatar Aug 27 '24 17:08 cielf

@cielf Fixed! The issue was similar to the one in another PR, where "some item -" was being used instead of "some item" when the default-unit was selected.

awwaiid avatar Sep 01 '24 13:09 awwaiid

@cielf Fixed the issue you ran into -- it was a case of qty 1 having a different pluralization than the header. I added a spec and fixed it.

awwaiid avatar Nov 25 '24 03:11 awwaiid

@awwaiid: Your PR Bank Org Request Export - Include Custom Units is part of today's Human Essentials production release: 2024.12.01. Thank you very much for your contribution!

github-actions[bot] avatar Dec 01 '24 15:12 github-actions[bot]