rubyforgood
4473 expand reminder date possibilities
Resolves #4473
Description
Replaces Reminder Day with Reminder Schedule. This is a recurring schedule that can occur on alternating months, or send reminders based on days of the week. Anywhere that a Organization or Partner Group could have a reminder day now has a reminder schedule.
Type of change
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
How Has This Been Tested?
System tests to walk through the process. Model tests to ensure the translation from the form to the ical schedule happens correctly. Validation tests to ensure that bad data doesn't get submitted.
Hi, @cielf , I'll get to work addressing those issues.
I believe the ice cube gem allows for "Last"...I'll implement that.
One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.
One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.
My assumption is that they either delete the date, if set to "Date", or choose the Blank Option in every Nth Day, if set to "Day of the Wee". But I wanted to confirm that.
Also, regarding these two corrections:
2/ The reminder date doesn't seem to be persisting. 3/ It's not giving an error if I enter a negative date.
Was the value for Every N Months empty when these happened? That's the only way I was able to recreate the errors (as I had written it that Every N Months blank meant no reminder, and thus no validation/saving.) If so, that's great news, as I'm removing the Every N Months. If there was a value for Every N Months when those bugs occurred, there's something else going on I have to figure out.
One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.
My assumption is that they either delete the date, if set to "Date", or choose the Blank Option in every Nth Day, if set to "Day of the Wee". But I wanted to confirm that.
That sounds good as a mechanic to me. It matches up to what they would do now.
Also, regarding these two corrections:
2/ The reminder date doesn't seem to be persisting. 3/ It's not giving an error if I enter a negative date.
Was the value for Every N Months empty when these happened? That's the only way I was able to recreate the errors (as I had written it that Every N Months blank meant no reminder, and thus no validation/saving.) If so, that's great news, as I'm removing the Every N Months. If there was a value for Every N Months when those bugs occurred, there's something else going on I have to figure out.
Might have been -- there's a placeholder of 1 and I might have just left it like that.
@dorner I'll be doing a final functional check on this in the next couple of days. Please take a technical review pass on it. Thanks.
Hey @jlandiseigsti Found an unexpected result...
If you have a deadline day of the 1st.
Then you click Day of Month and put 1 in the reminder date, you get an error, "Reminder day cannot be the same as deadline day." Which is fine.
But if you then click Day of the Week, and set the Reminder Day of the Week to Second Sunday, you still have the error (see below)
(Edit: I went in and cleared the reminder day and it still wouldn't clear the error)
Hey @jlandiseigsti -- are you still working on this, or shall we see if we can get someone else to finish up?
Hey @jlandiseigsti -- are you still working on this, or shall we see if we can get someone else to finish up?
Hi @cielf – I think it would be best if I handed it off right now. Life's gotten kind of hectic and I'm not sure when I'll be able to devote the time to finishing it.
@jlandiseigsti Ok, I'l mark it "Help Wanted", pointing to this PR. If no one picks it up, please feel free to continue with it if things get calmer.