human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Enable read-events feature in dev/staging by default

Open awwaiid opened this issue 1 year ago • 2 comments

We have manually enabled this in production.

awwaiid avatar Aug 11 '24 15:08 awwaiid

So I think we need to change the code here: https://github.com/rubyforgood/human-essentials/blob/d648cb3fad29456633a927226bd1f0453e4e405c/spec/rails_helper.rb#L174-L174

Right now it only forces true if the env variable is true. I think we need to force false if it's not true.

dorner avatar Aug 16 '24 19:08 dorner

Right now it only forces true if the env variable is true. I think we need to force false if it's not true.

I made a further change that removes this, and then event-mode github actions, altogether

awwaiid avatar Aug 21 '24 00:08 awwaiid

I'm sure! No going back! The issue last week is likely exactly the sort of issue we have without Events except without Events it is untracable and unfixable.

awwaiid avatar Sep 02 '24 20:09 awwaiid

I agree with Brock -- I really don't think we're going back at this point. I'm not quite ready to rip out the old stuff entirely , but we should have what developers are working with by default be what the banks are working with.

cielf avatar Sep 03 '24 08:09 cielf

On we go then!

dorner avatar Sep 03 '24 15:09 dorner

@awwaiid: Your PR Enable read-events feature in dev/staging by default is part of today's Human Essentials production release: 2024.09.08. Thank you very much for your contribution!

github-actions[bot] avatar Sep 08 '24 14:09 github-actions[bot]