human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Show inventory history for pre-event read

Open dorner opened this issue 1 year ago • 4 comments

Fix for #4433 .

This will show inventory history regardless of whether the time selected had events active or not. If the time is before events were active, it will use inventory item versions (using paper_trail).

dorner avatar Jun 21 '24 19:06 dorner

Hey @awwaiid I'll be reviewing this functionally tomorrow (hopefully pre-meeting). I fully expect it to work. Could you do a technical review in parallel?

cielf avatar Jun 23 '24 01:06 cielf

Looks like it works, ish-- the totals are wrong, and they are wrong for everyone on the production branch as well - i suspect it's just showing the current total inventory and that it has always been wrong but haven't looked into it. That is out of scope for this issue, I guess, but I would not be at all averse to including a fix for that in. (but am adding a proto issue)

cielf avatar Jun 23 '24 12:06 cielf

Fixed for the events_read cases (both within event time and before it).

dorner avatar Jun 23 '24 14:06 dorner

LGTM. Waiting for @awwaiid's review.

cielf avatar Jun 24 '24 17:06 cielf

@dorner: Your PR Show inventory history for pre-event read is part of today's Human Essentials production release: 2024.07.07. Thank you very much for your contribution!

github-actions[bot] avatar Jul 07 '24 14:07 github-actions[bot]