human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

#3067: add required info on csv partner export (partial solution)

Open callmarx opened this issue 1 year ago • 3 comments

Partial #3067

Description

This is a partial solution for the issue that includes only the following into the partner agencies export:

  • Agency address (line 1 and line 2)
  • Agency city
  • Agency state
  • Agency zip code
  • website
  • Agency type

As this is my first PR and contact with the project, I intend to make another one to include the information "providing diapers" and "providing period supplies" when I got a better overview of it.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Successful passed on rspec test, which I included into the partner model test, and check it manually the download based on seeds data

Screenshots

unnecessary

callmarx avatar Mar 26 '24 23:03 callmarx

Background for whoever is reviewing (probably @dorner) -- @callmarx is new to open source but experienced in Ruby - I suggested doing a partial on this as a Good First Issue since we are out of those and Difficulty-Beginner at the moment.

cielf avatar Mar 27 '24 02:03 cielf

Hi @cielf, I fixed the minor functionality quibbles and implemented a solution to include other_agency_type info when agency_type is Partner::AGENCY_TYPES["OTHER"]

callmarx avatar Mar 27 '24 19:03 callmarx

@callmarx there's a failing test - can you fix it?

dorner avatar Mar 28 '24 15:03 dorner

@callmarx: Your PR #3067: add required info on csv partner export (partial solution) is part of today's Human Essentials production release: 2024.06.16. Thank you very much for your contribution!

github-actions[bot] avatar Jun 16 '24 14:06 github-actions[bot]