human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

distributions view and export— on item filter or item category filter, number of items should reflect items chosen

Open cielf opened this issue 3 years ago • 0 comments

Summary

On the distiributions view, if you filter by items (or, when added, by item category), the # of items shown should be the number of items in the distribution that match that item/category, rather than then total # of items in the distribution. The export must be adjusted to match.

Justification

Discussed in stakeholder meeting 2022/08/03. The question that people are asking when they come to this screen and do those filters is "how many X were distributed", not "what was the total number of items in distributions that had X in them", which is what they get now.

Details

On the distribution index, the # of items must be the number of items that match the items (or items category, when that is added) filter. On the distribution export, the # of items must be the number of items that match the items (or items category, when that is added) filter.

Things you should know

This would pair very well with #3070

Criteria for completion

  • [ ] any existing tests updated appropriately. If no existing tests of # of items for this filter, add test(s)
  • [ ] # of items in the distributions view, under the item filter match the number of that item as described above
  • [ ] # of items in the distributions export, under the item filter match the number of that item as described above
  • [ ] Similarly for item category, if it has been implemented. (See upcoming issue)

cielf avatar Aug 04 '22 16:08 cielf